-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test preadv and pwritev on more operating systems #1606
Conversation
This was an oversight from PR nix-rust#1511
Big Sur is the first OSX version that supports preadv/pwritev
@rtzoeller do you know what's going on with the Dragonfly build? |
@asomers I think it's related to this commit, but I'm not sure what the actual issue is. I'll look into it. |
@asomers I think rust-lang/rust@e68887e is just a bad change? Per Will removing DragonFly from @devnexen does rust-lang/rust@e68887e compile for you? |
It will, but then we'll be cursed with a nasty "failing build x" on our github page. What about pinning the toolchain to a specific nightly version for the Dragonfly build? |
I like that idea. Shall we try the commit/day prior to rust-lang/rust@e68887e? |
In the meantime will fix the build on rust, thanks for spotting this. |
Yeah, I'll try it. |
3e1e6c7
to
4199697
Compare
Newer rustc is broken on DragonflyBSD, probably by rust-lang/rust@e68887e
@rtzoeller should be good to review now |
bors r+ |
This was an oversight from PR #1511. Also, update the OSX test environment for Big Sur. Big Sur is the first OSX version that supports preadv/pwritev