Add fdatasync for missing platforms #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IOU a changelog note, once the changelog has been updated for the next minor release (assuming the current changelog section is for a patch release). |
|
Yep yep yep. BTW, FreeBSD has had an fdatasync since 11.1, but it's equivalent to fsync on ZFS, which is the only file system many users care about. |
asomers
approved these changes
Dec 15, 2021
|
@rtzoeller time for a rebase and CHANGELOG notice? |
|
bors r+ |
|
Merge conflict. |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These platforms stub out
fdatasync()by just callingfsync(), but that is a conforming implementation.DragonFly recently provided an implementation, but it has not made it into a release or rust-lang/libc.