Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl AsRawFd for OwningIter #1563

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Impl AsRawFd for OwningIter #1563

merged 2 commits into from
Feb 7, 2022

Conversation

deantvv
Copy link
Contributor

@deantvv deantvv commented Oct 16, 2021

For issue #1558

@asomers
Copy link
Member

asomers commented Oct 16, 2021

I think this is a reasonable addition. Could you add a CHANGELOG entry please?

@asomers asomers added this to the 0.24.0 milestone Oct 16, 2021
@deantvv
Copy link
Contributor Author

deantvv commented Oct 17, 2021

@asomers CHANGELOG updated.

@rtzoeller
Copy link
Collaborator

@deantvv can you rebase to fix the changelog conflict? Thanks!

@deantvv deantvv force-pushed the owningiter-asrawfd branch from 4a478c8 to 845b7b8 Compare February 6, 2022 05:58
@deantvv deantvv force-pushed the owningiter-asrawfd branch from 845b7b8 to 08e40c0 Compare February 7, 2022 13:40
@deantvv
Copy link
Contributor Author

deantvv commented Feb 7, 2022

@rtzoeller Just rebased to resolved CHANGELOG conflict.

@rtzoeller
Copy link
Collaborator

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 7, 2022

Build succeeded:

@bors bors bot merged commit 0244b83 into nix-rust:master Feb 7, 2022
@deantvv deantvv mentioned this pull request Feb 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@deantvv @asomers @rtzoeller