Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

posix_fadvise doesn't return -1 as sentinel value #1538

Merged
merged 1 commit into from
Sep 29, 2021
Merged

posix_fadvise doesn't return -1 as sentinel value #1538

merged 1 commit into from
Sep 29, 2021

Conversation

ocadaruma
Copy link
Contributor

@ocadaruma ocadaruma commented Sep 23, 2021 •
edited
Loading

Summary

@ocadaruma ocadaruma changed the title posix_fadvise doesn't return -1 as sentinel value in linux posix_fadvise doesn't return -1 as sentinel value in linux and freebsd Sep 23, 2021
@ocadaruma ocadaruma marked this pull request as ready for review September 23, 2021 12:06
asomers
asomers reviewed Sep 25, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a good change. But why just Linux and FreeBSD? I think it probably returns directly on every OS.

@ocadaruma
Copy link
Contributor Author

I think it probably returns directly on every OS

H-m, sounds correct. Let me update.

@ocadaruma ocadaruma changed the title posix_fadvise doesn't return -1 as sentinel value in linux and freebsd posix_fadvise doesn't return -1 as sentinel value Sep 26, 2021
@ocadaruma ocadaruma requested a review from asomers September 26, 2021 00:57
asomers
asomers requested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please add an entry to the FIXED section of the CHANGELOG?

@ocadaruma ocadaruma requested a review from asomers September 28, 2021 04:14
asomers
asomers approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ocadaruma @asomers
Fix return value of posix_fadvise
a607034 
libc::posix_fadvise returns errnos directly rather than in the errno
variable.
@asomers
Copy link
Member

asomers commented Sep 29, 2021

bors r+

@bors bors bot merged commit 150579c into nix-rust:master Sep 29, 2021
@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

Build succeeded:

@ocadaruma ocadaruma deleted the fix-posix-fadvise branch October 3, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocadaruma @asomers