Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several problems with Errno aliases #1452

Merged
merged 3 commits into from
Jun 13, 2021
Merged

Fix several problems with Errno aliases #1452

merged 3 commits into from
Jun 13, 2021

Conversation

asomers
Copy link
Member

@asomers asomers commented Jun 13, 2021

  • Add Errno::EOPNOTSUPP to FreeBSD, where it is missing
  • Errno aliases are now associated consts of the Errno type
  • Remove Errno consts from platforms where they aren't defined

asomers added 3 commits June 12, 2021 18:06
@asomers
Remove Errno consts from platforms where they aren't defined.
5494b74 
Previously these were aliases for UnknownErrno.  Now, they're compile
errors.
@asomers
Errno aliases are now associated consts of the Errno type.
4da2e02 
Previously they had to be consts in the errno module, because associated
consts weren't supported until Rust 1.20.0.  Now that they're associated
consts, they can be used interchangeably with regular Errno enum
variants.
@asomers
Add Errno::EOPNOTSUPP to FreeBSD, where it is missing
6f15bf3
@asomers asomers merged commit af2ee71 into nix-rust:master Jun 13, 2021
@asomers asomers deleted the errno-values branch June 13, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asomers