Support vsock on Android as well as Linux. #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The libc change has now been merged and released, please review. |
|
The CI failure looks unrelated to my change as far as I can tell, is there some way to rerun it? |
|
I think that failure is due to a bug in glibc. I restarted it. But note this warning, that is probably related to your PR: |
|
Ah, that might be because of the libc version upgrade. Fixed now. |
|
Looks good. Now please squash your commits. |
|
Also, looks like you'll need to rebase. |
Fix deprecation warning from libc update.
|
Thanks, rebased and squashed. |
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Oct 12, 2020
1307: Release v0.19.0. r=kamalmarhubi a=qwandor-google I'd like to get a new version of the crate released including #1301 so that I can get the vsock crate building on Android, and get both imported into the Android tree. Co-authored-by: Andrew Walbran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change depends on rust-lang/libc#1905 so can't be merged until that is merged and released.