Remove several deprecated constants and functions #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Some tests still use |
* `unistd::daemon` on Apple * `unistd::pipe2` on Apple * `sys::event::FilterFlag::NOTE_EXIT_REPARENTED` on Apple * `sys::event::FilterFlag::NOTE_REAP` on Apple * `sys::ptrace::ptrace` on Android and Linux All have been deprecated for more than two releases and one year.
asomers
force-pushed
the
remove_deprecated2
branch
from
f71f3b1 to
f698fd3
Compare
|
I fixed the cfg gate on the test, and tweaked the formatting of the man page. |
Susurrus
reviewed
Jun 5, 2020
test/test_unistd.rs
Outdated
| target_os = "emscripten", | ||
| target_os = "freebsd", | ||
| target_os = "linux", | ||
| target_os = "redox", |
CHANGELOG.md
Outdated
| @@ -69,6 +69,12 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
| optional arguments. | |||
| (#[1242](https://github.com/nix-rust/nix/pull/1242)) | |||
|
|
|||
| - Removed `unistd::daemon`, `unistd::pipe2`, | |||
| `sys::event::FilterFlag::NOTE_EXIT_REPARENTED`, and | |||
| `sys::event::FilterFlag::NOTE_REAP` on OSX and ios. Removed | |||
There was a problem hiding this comment.
I'd split these as separate line items since they aren't really related even though they're part of the same PR.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 12, 2020
1255: Remove several deprecated constants and functions r=asomers a=asomers * `unistd::daemon` on Apple * `unistd::pipe2` on Apple * `sys::event::FilterFlag::NOTE_EXIT_REPARENTED` on Apple * `sys::event::FilterFlag::NOTE_REAP` on Apple * `sys::ptrace::ptrace` on Android and Linux All have been deprecated for more than two releases and one year. Co-authored-by: Alan Somers <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
|
It's unfortunate that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unistd::daemonon Appleunistd::pipe2on Applesys::event::FilterFlag::NOTE_EXIT_REPARENTEDon Applesys::event::FilterFlag::NOTE_REAPon Applesys::ptrace::ptraceon Android and LinuxAll have been deprecated for more than two releases and one year.