Raise minimum supported Rust version to 1.36.0 #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
requested changes
Aug 22, 2019
The minimum supported Rust version is being raised to 1.36.0 as this is the first release to support the `mem::MaybeUninit` feature. Signed-off-by: Otavio Salvador <[email protected]>
|
@asomers I rebased this on top of current master; please take a look. |
|
Please note in the commit message the reason for raising the msrv. Otherwise, it looks good. |
|
It is, on the long description. |
|
Ahh, my apologies. I didn't see it on my tiny cell phone screen. I'll take a look at the musl failure. |
Weirdly, musl uses i32 to store the ioctl opcode
bors bot
added a commit
that referenced
this pull request
Aug 29, 2019
1108: Raise minimum supported Rust version to 1.36.0 r=asomers a=otavio Signed-off-by: Otavio Salvador <[email protected]> Co-authored-by: Otavio Salvador <[email protected]> Co-authored-by: Alan Somers <[email protected]>
Build succeeded
|
bors bot
added a commit
that referenced
this pull request
Sep 21, 2019
1126: Relax some dependency versions r=asomers a=atouchet The minimum supported Rust version was bumped in #1108 so these restrictions are no longer necessary. Co-authored-by: Alex Touchet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Otavio Salvador [email protected]