socket: expose MSG_WAITALL in MsgFlags #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a CHANGELOG entry. Otherwise it looks good. |
stefano-garzarella
force-pushed
the
waitall-master
branch
from
810b24e to
78dec21
Compare
Thanks, I just added the entry in the CHANGELOG. |
|
@asomers I updated my commit adding the entry in the CHANGELOG and I did a force-pushed to use this PR. Let me know if it is okay. |
|
I'm sorry, but you'll need to rebase. I made a release yesterday so your CHANGELOG entry isn't going to merge correctly. |
MSG_WAITALL can be useful with recv() to wait the full amount of data requested. Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
force-pushed
the
waitall-master
branch
from
78dec21 to
3ffbd40
Compare
|
@asomers don't worry :), I rebased and force-pushed. |
bors bot
added a commit
that referenced
this pull request
Jun 7, 2019
1079: socket: expose MSG_WAITALL in MsgFlags r=asomers a=stefano-garzarella MSG_WAITALL can be useful with recv() to wait the full amount of data requested. Co-authored-by: Stefano Garzarella <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSG_WAITALL can be useful with recv() to wait the full amount of data requested.