Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unistd::{seteuid,setegid} #1044

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Add unistd::{seteuid,setegid} #1044

merged 1 commit into from
Apr 14, 2019

Conversation

jmmv
Copy link
Contributor

@jmmv jmmv commented Apr 11, 2019

This is for the benefit of those platforms that do not provide setresuid
nor setresgid, like macOS.

@asomers
Copy link
Member

asomers commented Apr 11, 2019

What a simple PR. This looks fine, except for the conflict.

@jmmv
Copy link
Contributor Author

jmmv commented Apr 11, 2019

Agh. I did the pull from the wrong repository. Rebased now.

@asomers
Copy link
Member

asomers commented Apr 11, 2019

Teehee, out of date again!

This is for the benefit of those platforms that do not provide setresuid
nor setresgid, like macOS.
@jmmv
Copy link
Contributor Author

jmmv commented Apr 11, 2019

Rebased again.

Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Apr 14, 2019
1044: Add unistd::{seteuid,setegid} r=asomers a=jmmv

This is for the benefit of those platforms that do not provide setresuid
nor setresgid, like macOS.

Co-authored-by: Julio Merino <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2019

Build succeeded

@bors bors bot merged commit 24d0e11 into nix-rust:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants