-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several errno values for OpenBSD #1036
Conversation
Yikes, those are some long lines! While you're here, would you mind wrapping them to 80 columns? |
Ha, yeah, I was wondering about that and decided just to mimic the line above. Should I just #[cfg(any(target_os = "macos", target_os = "freebsd",
target_os = "dragonfly", target_os = "ios",
target_os = "openbsd", target_os = "netbsd"))]
EPROTO => "Protocol error", It wraps some of the other cfg lines also in more or less the same style. |
I'm not a fan of everything that rustfmt does. I wouldn't use it on parts of the file that you aren't changing. |
Sounds good. Should I go ahead and wrap those other really long lines I was mimicking? |
Is it mainly formatting that is holding this back? It would be helpful to have this available, because newer versions of some packages I depend on already check for EPROTO and won't compile on OpenBSD, forcing me to stay with older versions. Thanks, |
Sorry if I came off demanding. I was merely just inquiring. Thanks! :-) --Rob |
I was actually just thinking of bumping this. It's blocking some wayland-related crates from compiling for me. |
Same! :) |
Thanks for handling the formatting. Could you please do two more things?
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
bors r+
1036: Add several errno values for OpenBSD r=asomers a=sourgrasses It looks like OpenBSD added several new errno values in 6.2, and they've already been added to `libc`, so this should allow any crates using those to build on OpenBSD. Co-authored-by: Jenn Wheeler <[email protected]>
Timed out |
Looks like Travis is super-slow today :'( . I'll try again late at night. |
bors r+ |
Merge conflict |
Sorry, but merging master isn't the right way to resolve the merge conflict. You need to rebase instead. |
Yeahhh, whoops lol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
1036: Add several errno values for OpenBSD r=asomers a=sourgrasses It looks like OpenBSD added several new errno values in 6.2, and they've already been added to `libc`, so this should allow any crates using those to build on OpenBSD. Co-authored-by: Jenn Wheeler <[email protected]>
Build succeeded
|
Thanks! |
It looks like OpenBSD added several new errno values in 6.2, and they've already been added to
libc
, so this should allow any crates using those to build on OpenBSD.