Fix the tests with libc 0.2.49 and Rust 1.33.0 #1033
Conversation
|
This should fix PR #1031 |
|
Can one of the @nix-rust/nix-maintainers with an OSX machine please verify whether Nix 0.13.0 can even build with libc 0.2.49? |
|
Ok, I'm stumped. Why didn't the |
|
I have a machine and can dig into this tonight if that'd be helpful.
…On March 1, 2019 8:24:19 AM PST, Alan Somers ***@***.***> wrote:
Ok, I'm stumped. Why didn't the `#[allow(deprecated)]` fix the tests
on OSX?
--
You are receiving this because you are on a team that was mentioned.
Reply to this email directly or view it on GitHub:
#1033 (comment)
|
|
That would indeed be helpful. But don't bother with my first question; 0.13.0 should still work fine, because we only |
|
Ok, I'm an idiot. I never actually committed the important part. |
|
The Linux failure looks like a regression in Cargo 1.33.0. I'll fix it. |
|
It looks like Cargo <= 1.32.0 would create a new thread for every test, even if Weirdly, this is a case where |
Several symbols are now marked as deprecated on OSX. Fix the build by marking these symbols' Nix wrappers as deprecated, too.
Previous versions of Cargo would create and destroy a new thread for each test. Cargo 1.33.0 instead creates a thread pool and reuses the same thread for multiple tests. Some Nix tests that changed the per-thread sigmask began to fail as a result, because they didn't do any cleanup. The easiest solution is to spawn a new thread for each of those tests.
It was disabled long ago and nobody remembered to reenable it. I'm guessing it's fixed by now.
asomers
changed the title
|
bors r+ |
1033: Fix the tests with libc 0.2.49 and Rust 1.33.0 r=asomers a=asomers Several symbols are now marked as deprecated on OSX. Co-authored-by: Alan Somers <[email protected]>
Build succeeded
|
Several symbols are now marked as deprecated on OSX.