Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #317 - Some event flags renaming #1024

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Fix for #317 - Some event flags renaming #1024

merged 1 commit into from
Feb 12, 2019

Conversation

amanjeev
Copy link
Contributor

@amanjeev amanjeev commented Feb 11, 2019 •
edited
Loading

I tried to grep and replace for #317. Please let me know if I need to fix something else as well but in my search I saw that most were fixed earlier.

Closes #317

@asomers
Copy link
Member

asomers commented Feb 12, 2019

Looks good! But could you please add a CHANGELOG entry and also describe what you did in your commit message?

@amanjeev
Copy link
Contributor Author

@asomers will do!

@amanjeev
PollFd event flags renamed to PollFlags from EventFlags.
1b2fadd 
Most of the EventFlags have been renamed already, but Poll was the only one remaining. This commit fixes that.

Issue 317 #317
asomers
asomers approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Feb 12, 2019
@bors @amanjeev
Merge #1024
1dd1d2a 
1024: Fix for #317 - Some event flags renaming r=asomers a=amanjeev

I tried to grep and replace for #317. Please let me know if I need to fix something else as well but in my search I saw that most were fixed earlier.

Co-authored-by: Amanjeev Sethi <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 12, 2019

Build succeeded

@bors bors bot merged commit 1b2fadd into nix-rust:master Feb 12, 2019
@amanjeev amanjeev mentioned this pull request Feb 12, 2019
Open
10 tasks
@drinkdhmo drinkdhmo mentioned this pull request May 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flag type names to match FOO_* => FooFlags convention
2 participants
@amanjeev @asomers