Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal::SigFlags should be enum instead of bitflags. #459

Closed
chaosagent opened this issue Nov 6, 2016 · 4 comments
Closed

signal::SigFlags should be enum instead of bitflags. #459

chaosagent opened this issue Nov 6, 2016 · 4 comments

Comments

@chaosagent
Copy link
Contributor

http://man7.org/linux/man-pages/man3/pthread_sigmask.3.html

SigFlags represents the how parameter of pthread_sigmask, which takes 3 mutually exclusive options, which should be represented by an enum. The SigFlags name is pretty confusing too, as the underlying value is an option, not a flag.
@chaosagent
Copy link
Contributor Author

Fixing this would require some breaking changes, but I don't know what the policy on that is.

@chaosagent chaosagent mentioned this issue Nov 6, 2016
Merged
@kamalmarhubi
Copy link
Member

Fixing this would require some breaking changes, but I don't know what the policy on that is.

A big part of the motivation for a changelog is to at least make it possible to see what has changed. Pre-1.0 we're fairly happy to make changes for API improvements. This is fixing the semantics of an API and should certainly be allowed, IMO.

@kamalmarhubi
Copy link
Member

For more on this parameter: http://man7.org/linux/man-pages/man2/sigprocmask.2.html#DESCRIPTION

Certainly agree this should be an enum.

homu added a commit that referenced this issue Nov 15, 2016
@homu
Auto merge of #460 - chaosagent:sys_signal, r=fiveop
8cda34d 
Change SigFlags into an enum.

Addresses #459.

This is a breaking change.

Should SigFlags be renamed to something more sensible?
@fiveop
Copy link
Contributor

fiveop commented Nov 15, 2016

#460 is merged, so this issue can be closed.

@fiveop fiveop closed this as completed Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kamalmarhubi @fiveop @chaosagent