Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning when compiling #346

Closed
szagi3891 opened this issue Apr 8, 2016 · 5 comments
Closed

Warning when compiling #346

szagi3891 opened this issue Apr 8, 2016 · 5 comments

Comments

@szagi3891
Copy link 

grzegorz@grzegorz:~/Pulpit/rust$ git clone https://github.com/nix-rust/nix
Cloning into 'nix'...
remote: Counting objects: 2904, done.
remote: Total 2904 (delta 0), reused 0 (delta 0), pack-reused 2904
Receiving objects: 100% (2904/2904), 751.82 KiB | 214.00 KiB/s, done.
Resolving deltas: 100% (2043/2043), done.
Checking connectivity... done.
grzegorz@grzegorz:~/Pulpit/rust/nix$ cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
 Downloading bitflags v0.4.0
 Downloading semver v0.1.20
 Downloading rustc_version v0.1.7
   Compiling libc v0.2.9
   Compiling semver v0.1.20
   Compiling rustc_version v0.1.7
   Compiling bitflags v0.4.0
   Compiling cfg-if v0.1.0
   Compiling nix v0.5.1-pre (file:///home/grzegorz/Pulpit/rust/nix)
src/sched.rs:208:20: 208:34 warning: `extern "C" fn(*mut Box<std::ops::FnMut() -> isize>) -> i32 {sched::clone::callback}` is now zero-sized and has to be cast to a pointer before transmuting to `*const extern "C" fn(*const Box<std::ops::FnMut() -> isize>) -> i32`, #[warn(transmute_from_fn_item_types)] on by default
src/sched.rs:208         ffi::clone(mem::transmute(callback), ptr as *mut c_void, flags.bits(), &mut cb)
                                    ^~~~~~~~~~~~~~
src/sched.rs:208:20: 208:34 warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
src/sched.rs:208:20: 208:34 note: for more information, see issue #19925 <https://github.com/rust-lang/rust/issues/19925>
grzegorz@grzegorz:~/Pulpit/rust/nix$

can you fix it?
@posborne
Copy link
Member

posborne commented Apr 8, 2016

@szagi3891 What version of rustc?

@fiveop
Copy link
Contributor

fiveop commented Apr 8, 2016

This is the relevant Rust issue: rust-lang/rust#19925 .

@szagi3891
Copy link
Author

It is the latest version. Today installed. Nightly (1.9)

gszeliga@dev4:~/workspace/nix$ cargo version
cargo 0.10.0-nightly (f20ca62 2016-04-06)

@fiveop fiveop mentioned this issue Apr 14, 2016
Merged
homu added a commit that referenced this issue Apr 18, 2016
@homu
Auto merge of #353 - fiveop:nightly_warning, r=kamalmarhubi
9d912ae 
Cast function item to function pointer in order to appease compiler.

This is necessary because of compiler changes. For further information
look at rust-lang/rust#19925.

This solves #346.

I know that there are other problems with the affected function. We are thinking about how to best pass the arguments to the function and we don't want to define the ffi's ourselves. However, I would like to get the warning out of our tree as soon as possible. We do not need to wait for our polish.
@kamalmarhubi
Copy link
Member

Fixed by #353.

@szagi3891
Copy link
Author

Cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@posborne @kamalmarhubi @fiveop @szagi3891