Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should maybe clarify that RLIM_INFINITY comes from libc #1803

Closed
hlavaatch opened this issue Aug 20, 2022 · 1 comment · Fixed by #1831
Closed

Should maybe clarify that RLIM_INFINITY comes from libc #1803

hlavaatch opened this issue Aug 20, 2022 · 1 comment · Fixed by #1831

Comments

@hlavaatch
Copy link

Doc for getrlimit and setrlimit mentions RLIM_INFINITY constant but doesn't mention it comes from the libc crate.
Maybe it should, or the constant could be re-exported in the nix::sys::resource namespace.
As it is now, search for RLIM_INFINITY in nix doc yields nothing, leaving user scratching his head :)
@asomers
Copy link
Member

asomers commented Aug 20, 2022

Good point. Reexporting it makes sense, I think. Would you care to submit a PR for that?

This was referenced Oct 2, 2022
Closed
Merged
bors bot added a commit that referenced this issue Oct 2, 2022
@bors @SteveLauC
Merge #1831
489d7cf 
1831: re-export RLIM_INFINITY from libc r=rtzoeller a=SteveLauC

Fixes #1803 

Co-authored-by: Steve Lau <[email protected]>
bors bot added a commit that referenced this issue Oct 3, 2022
@bors @SteveLauC
Merge #1831
482a596 
1831: re-export RLIM_INFINITY from libc r=rtzoeller a=SteveLauC

Fixes #1803 

Co-authored-by: Steve Lau <[email protected]>
@bors bors bot closed this as completed in e5913c6 Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

re-export RLIM_INFINITY from libc SteveLauC/nix
re-export RLIM_INFINITY from libc SteveLauC/nix
2 participants
@asomers @hlavaatch