-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing EventFlag bitflags on OpenBSD (EV_DISPATCH, EV_RECEIPT) #1251
Comments
Sure, just submit a PR. Note that Nix doesn't build for OpenBSD in CI; so we rely on our users to catch even basic build problems. |
fwiw, sr.ht offers OpenBSD CI - there are even convenient dispatchers for building from Github commits! |
Yes. However, sr.ht isn't free, and none of Nix's maintainers are OpenBSD users, so we haven't stumped up for it. |
I have opened #1252. Thanks! |
sr.ht is free. I'm using it for OpenBSD builds myself. After the alpha it will no longer be free but you can unlock all features for $2/month. It's also much faster than cirrus for FreeBSD builds. |
My interpretation is that it's free for evaluation purposes, but you're kind of a jerk if you abuse the privilege. Am I wrong? |
I believe you are wrong. |
1252: Add EV_DISPATCH, EV_RECEIPT items for EventFlags, and fix build on OpenBSD r=asomers a=nickpelone This pull request: - Adds `EV_DISPATCH` and `EV_RECEIPT` to `EventFlags`. OpenBSD supports these now. c379d1a - Fixes a regression that caused `nix` to be unable to build on OpenBSD since #1208. dd0a990 - Makes a change to avoid a deprecation warning from `libc` crate, which breaks tests. 0f9fcbd Since I know y'all don't have OpenBSD in CI right now, I've attached the results of a `cargo test` run on OpenBSD 6.7. Thanks for your time! [testresults.txt](https://github.com/nix-rust/nix/files/4684597/testresults.txt) Fixes #1251 Co-authored-by: Nick Pelone <[email protected]>
Hey there!
OpenBSD has been excluded from
EV_DISPATCH
andEV_RECEIPT
for a while now, but they have since landed in OpenBSD (A while ago, pretty sure.)These being excluded on that platform prevent crates such as
smol
from building (related issue: smol-rs/smol#146)Any way these can be added for
target_os = "openbsd"
?Thanks for your time.
The text was updated successfully, but these errors were encountered: