Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fallocate shouldn't return c_int #1200

Closed
DianaNites opened this issue Mar 28, 2020 · 1 comment · Fixed by #1201
Closed

fallocate shouldn't return c_int #1200

DianaNites opened this issue Mar 28, 2020 · 1 comment · Fixed by #1201

Comments

@DianaNites
Copy link
Contributor

fallocate, like posix_fallocate, doesn't have a meaningful return value.

From the man page

On success, fallocate() returns zero. On error, -1 is returned and errno is set to indicate the error.
@asomers
Copy link
Member

asomers commented Mar 28, 2020

Yep, that's correct. Care to submit a PR to change it?

@DianaNites DianaNites mentioned this issue Mar 28, 2020
Merged
bors bot added a commit that referenced this issue Mar 28, 2020
@bors @DianaNites
Merge #1201
b5a129a 
1201: Fix fallocate signature r=asomers a=DianaNites

Fixes #1200 

Co-authored-by: Diana <[email protected]>
@bors bors bot closed this as completed in 9064823 Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fallocate signature
2 participants
@asomers @DianaNites