Add manylinux support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zimbatm @adisbladis care to have a quick look already? Especially the refactoring @andir and I put some effort into it and there is a small part left still. Obviously this will get harder to keep up to date once more stuff gets merged. I think the refactoring should be quite beneficial and make the code easier to work with.. |
Provides a `select` function that picks the most appropriate `.whl` file based on platform, arch, python version and manylinux/OSX - version. - Adds unit tests for pep425 - Adds test for manylinux support - Fixes overrides: `passhtru` must be extended, not overwritten - Don't strip python packages: this screws up manylinux binaries
- Extract utility functions to ./lib.nix - Extract buildPythonPackage to ./mk-poetry-dep.nix - Replace some functions with existing builtin functions - Use lib.partition for python package splitting - Drop package filtering on the top-level and leave it to pep425.nix
gilligan
force-pushed
the
manylinux-support
branch
from
f1421c2 to
5741d9e
Compare
As per NixOS/nixpkgs#75763 this environment variable is not needed anymore. Instead python interpreters are now assuming compatibility by default.
The manylinux support works but needs to remain disabled until the necessary nixpkgs changes have been merged and propagated.
FRidh
suggested changes
Dec 17, 2019
|
haven't checked in detail but on a glance this looks good to me. |
Drp `poetrylock` and `pyproject` mandatory arguments without default values and drops `src` from `mkPoetryPyhon`. Fix test invocations with invalid arguments.
Make sure that whl files using notation such as "py2|py3|py2.py3" and/or files using "any" in the `abi` tag are accepted as well.
gilligan
force-pushed
the
manylinux-support
branch
2 times, most recently
from
29915be to
d8eb359
Compare
- Add info on mkPoetryApplication - Add info on mkPoetryEnv - Add info about manylinux
gilligan
force-pushed
the
manylinux-support
branch
from
d8eb359 to
54b4370
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds manylinux support to poetry2nix. It depends on a nixpkgs revision that has the following changes:
_manylinux.pyfiles from python interpretersAdditional Info
selectWheel: The added
pep425.nixprovides aselectWheelfunction which picks a preferred.whlbased on python version, arch and some heuristics. HoweverselectWheelis only ever used if no source distribution is available.mkPoetryEnv: Provides a python environment with the packages specified by poetry. This is useful in scenarios when you don't want to actually build a python application per se but instead want to provide an python environment to work with.
Refactoring The PR also contains quite some refactoring which aims to make the code base easier to use with. On several occasions code was extracted, let bindings reduced or some functions could be replaced with builtin or lib functions.
Some additional work was required to get this over the finish line...
py2orpy3and especiallypy2.py3would not be picked up. I fixed all of that and added proper tests for those scenarios.mkPoetryEnvwhere all packages specified in the poetry lock file are readily available. If you usemkPoetryPythonwithout actually forcing/referencing to some poetry dependency you will get a vanilla python package instead.poetryLocktomkPoetryApplicationwhich doesn't even exist. However the combination of a default argument and...for additional arguments meant this remained unnoticed. I removed the default arguments and also removedsrcfrommkPoetryPythonandmkPoetryEnvwhich both don't need it.