Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/user-guide: add lazy-loading.md #2630

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Dec 10, 2024

Just getting this started and creating a draft PR if anyone has input on what they'd like mentioned.

@khaneliman khaneliman force-pushed the lazy-docs branch 2 times, most recently from 770c60b to f6e30be Compare December 10, 2024 23:59
@khaneliman khaneliman force-pushed the lazy-docs branch 6 times, most recently from 1cda6aa to 8a74f41 Compare December 13, 2024 04:21
@khaneliman khaneliman marked this pull request as ready for review December 14, 2024 01:41
@khaneliman
Copy link
Contributor Author

Marking as ready.. curious if there's anything else other's want added.

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions below.

Do you have any goals in mind before you undraft?

My preference would be to get an initial version of this guide merged soon and then make improvements to it iteratively.

Thanks for working on this, it's looking amazing! 🚀

docs/user-guide/lazy-loading.md Outdated Show resolved Hide resolved
docs/user-guide/lazy-loading.md Outdated Show resolved Hide resolved
docs/user-guide/lazy-loading.md Outdated Show resolved Hide resolved
docs/user-guide/lazy-loading.md Outdated Show resolved Hide resolved
@khaneliman
Copy link
Contributor Author

Do you have any goals in mind before you undraft?

My preference would be to get an initial version of this guide merged soon and then make improvements to it iteratively.

Thanks for working on this, it's looking amazing! 🚀

Thanks, I realized I had been letting it draft too long so I undrafted it just before your review. :P

@khaneliman khaneliman force-pushed the lazy-docs branch 2 times, most recently from f6b1fd3 to 6d5d4fc Compare December 14, 2024 02:17
docs/user-guide/lazy-loading.md Outdated Show resolved Hide resolved
docs/user-guide/lazy-loading.md Outdated Show resolved Hide resolved
docs/user-guide/lazy-loading.md Outdated Show resolved Hide resolved
@khaneliman khaneliman force-pushed the lazy-docs branch 2 times, most recently from 88cd15a to cb9d6f4 Compare December 14, 2024 03:10
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent addition to the docs. Thanks! 📑

@khaneliman
Copy link
Contributor Author

@mergify queue

Copy link
Contributor

mergify bot commented Dec 14, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e8e3965

Copy link
Contributor

mergify bot commented Dec 14, 2024

This pull request, with head sha e8e396558b52be4319d93b995da91b16fd9793b7, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha e8e396558b52be4319d93b995da91b16fd9793b7 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch lazy-docs, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit e8e3965 into nix-community:main Dec 14, 2024
4 checks passed
@khaneliman khaneliman deleted the lazy-docs branch December 14, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants