-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop some aliases #1884
Drop some aliases #1884
Conversation
We have some buildbot issues that drown real test failures, sorry :/ |
Thanks for this! In addition to @traxys feedback ( Or if you prefer two commits:
|
both things done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SuperSandro2000 !
Thanks! Until #1878 is resolved, we'll have to test locally. |
I normally rebuild my config with the changes before opening the PR but I regularly forget it when applying review changes 🤦🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, should be simple enough we can merge without CI
No description provided.