Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop some aliases #1884

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Drop some aliases #1884

merged 1 commit into from
Jul 19, 2024

Conversation

SuperSandro2000
Copy link
Member

No description provided.

@traxys
Copy link
Member

traxys commented Jul 17, 2024

none-ls seemed to rely on the entry being named treefmt, you need to set treefmt = treemft2 instead of the inherit

We have some buildbot issues that drown real test failures, sorry :/

@MattSturgeon
Copy link
Member

Thanks for this!

In addition to @traxys feedback (treefmt = treemft2), could you reword the commit using the format plugins/{lsp,none-ls}: remove package aliases?

Or if you prefer two commits:

  • plugins/lsp: remove typescript-language-server alias
  • plugins/none-ls: remove treefmt + markdownlint-cli aliases

@SuperSandro2000
Copy link
Member Author

both things done :)

Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SuperSandro2000 !

@GaetanLepage
Copy link
Member

@MattSturgeon
Copy link
Member

Thanks!

Until #1878 is resolved, we'll have to test locally.

@SuperSandro2000
Copy link
Member Author

I normally rebuild my config with the changes before opening the PR but I regularly forget it when applying review changes 🤦🏼

Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be simple enough we can merge without CI

@traxys traxys merged commit 8a4dc23 into nix-community:main Jul 19, 2024
71 of 76 checks passed
@SuperSandro2000 SuperSandro2000 deleted the remove-aliases branch July 19, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants