Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mopidy: restart service on config changes #6072

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

jwillikers
Copy link
Contributor

Description

The Mopidy service is not restarted when the config changes.
This PR adds X-Restart-Triggers to the unit to ensure that the service is restarted on config file changes.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@foo-dogsquared

Also extend basic configuration test a bit to verify the restart
trigger.
@rycee rycee merged commit a995363 into nix-community:master Nov 24, 2024
2 of 3 checks passed
@rycee
Copy link
Member

rycee commented Nov 24, 2024

Thanks! I extended the test a bit and merged to master now 🙂

@jwillikers jwillikers deleted the mopidy-restart-service branch November 24, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants