Implemented rewrite to real path in dump_path #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
virtual-store
branch
3 times, most recently
from
df50080 to
d255e31
Compare
Thesola10
reviewed
Apr 18, 2024
Mic92
force-pushed
the
virtual-store
branch
3 times, most recently
from
fa3ba82 to
38550fc
Compare
|
LGTM, mind if I re-sign this and push it into my original PR? |
|
@Thesola10 sure. |
This fixes #254 by adding a function, get_real_store_dir, to libnixstore to support non-root nix stores, where the physical and logical paths differ. prettier code Applied formatter and clippy recommendation Fixed string comparison Added test cases, fixed web serve paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #254 by adding a function, get_real_store_dir, to libnixstore to support non-root nix stores, where the physical and logical paths differ.