Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for non-root Nix store #306

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Added support for non-root Nix store #306

merged 2 commits into from
Apr 18, 2024

Conversation

Thesola10
Copy link

@Thesola10 Thesola10 commented Apr 4, 2024

This fixes #254 by adding a function, get_real_store_dir, to libnixstore to support non-root nix stores, where the physical and logical paths differ.

@Thesola10 Thesola10 marked this pull request as ready for review April 4, 2024 11:55
@Thesola10 Thesola10 changed the title Implemented rewrite to real path in dump_path Added support for non-root Nix store Apr 4, 2024
@Thesola10
Copy link
Author

@Mic92 could you have a look?

@Mic92
Copy link
Member

Mic92 commented Apr 18, 2024

I optimized allocations a bit. Can you check out this one? https://github.com/nix-community/harmonia/pull/315/files

@Mic92
Copy link
Member

Mic92 commented Apr 18, 2024

nix fmt should fix the ci issue.

This fixes #254 by adding a function, get_real_store_dir, to libnixstore
to support non-root nix stores, where the physical and logical paths
differ.

Co-authored-by: Jörg Thalheim <[email protected]>
@Mic92
Copy link
Member

Mic92 commented Apr 18, 2024

@mergify queue

Copy link

mergify bot commented Apr 18, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7f4ad51

@mergify mergify bot merged commit 7f4ad51 into nix-community:master Apr 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying alternative store root
2 participants