Fix crateOverrides #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have been implemented at some time in the past, but got lost, since the documentation talks about crateOverrides, and the crateOverrides variable is passed around only for nothing to happen with it.
|
Funny, I just created #94 :) |
|
The intention was to pass it to I think that is still a good idea. And this time, we should definitely add an integration test for that. |
|
Oh, I am obviously also happy about README.md corrections and/or issues if something is unclear or wrong. |
|
I'll probably have a go at fixing this. Let me know if you'd rather do it! @alyssais |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been implemented at some time in the past, but got
lost, since the documentation talks about crateOverrides, and the
crateOverrides variable is passed around only for nothing to happen
with it.