Cleanup rust #26
Merged
Cleanup rust #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
reviewed
Jul 3, 2022
|
Thank you |
- Borrow command + trail instead of moving out of args - Use the new std::process:ExitCode api instead of calling std::process:exit() - Produce better error messages on invalid picker output
Sciencentistguy
force-pushed
the
cleanup-rust
branch
from
a4fa3d5 to
0b06f42
Compare
|
Been running this for 2 days and so far no issues Always nice to see better rust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::process:ExitCodeapi instead of callingstd::process:exit()