Fix the PICS condition for reading Presets attribute

- Remove the read for schedules since the test plan doesn't cover it
nivi-apple · Aug 8, 2024 · 618237d · 618237d
1 parent ce5d2e3
commit 618237d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 20 deletions.
diff --git a/src/app/tests/suites/certification/Test_TC_TSTAT_4_1.yaml b/src/app/tests/suites/certification/Test_TC_TSTAT_4_1.yaml
@@ -62,49 +62,34 @@ tests:
       response:
           saveAs: PresetsValue
 
-    - label: "Saving value for comparision in step 6 read Schedules attribute"
-      PICS: TSTAT.S.A0051
-      command: "readAttribute"
-      attribute: "Schedules"
-      response:
-          saveAs: SchedulesValue
-
     - label: "Step 2: TH reads the PresetTypes attribute from the DUT"
-      PICS: TSTAT.S.F08 & TSTAT.S.A0048
+      PICS: TSTAT.S.F08 && TSTAT.S.A0048
       command: "readAttribute"
       attribute: "PresetTypes"
       response:
           constraints:
               type: list
 
     - label: "Step 3: TH reads the NumberOfPresets attribute from the DUT"
-      PICS: TSTAT.S.F08 & TSTAT.S.A004a
+      PICS: TSTAT.S.F08 && TSTAT.S.A004a
       command: "readAttribute"
       attribute: "NumberOfPresets"
       response:
           constraints:
               type: int8u
 
     - label: "Step 4: TH reads the ActivePresetHandle attribute from the DUT"
-      PICS: TSTAT.S.F08 & TSTAT.S.A004e
+      PICS: TSTAT.S.F08 && TSTAT.S.A004e
       command: "readAttribute"
       attribute: "ActivePresetHandle"
       response:
           constraints:
               type: octstr
 
     - label: "Step 5: TH reads the Presets attribute from the DUT"
-      PICS: TSTAT.S.F08 & TSTAT.S.A0050
+      PICS: TSTAT.S.F08 && TSTAT.S.A0050
       command: "readAttribute"
       attribute: "Presets"
       response:
           constraints:
               type: list
-
-    - label: "Step 6: TH reads the Schedules attribute from the DUT"
-      PICS: TSTAT.S.F07 & TSTAT.S.A0051
-      command: "readAttribute"
-      attribute: "Schedules"
-      response:
-          constraints:
-              type: list
diff --git a/src/app/tests/suites/certification/ci-pics-values b/src/app/tests/suites/certification/ci-pics-values
@@ -1931,6 +1931,7 @@ TSTAT.S.F03=0
 TSTAT.S.F04=0
 TSTAT.S.F05=1
 TSTAT.S.F06=0
+TSTAT.S.F07=0
 TSTAT.S.F08=1
 
 TSTAT.S.A0000=1
@@ -1987,7 +1988,7 @@ TSTAT.S.A0048=1
 TSTAT.S.A004a=1
 TSTAT.S.A004e=1
 TSTAT.S.A0050=1
-TSTAT.S.A0051=1
+TSTAT.S.A0051=0
 
 TSTAT.S.M.MinSetpointDeadBandWritable=1
 TSTAT.S.M.HVACSystemTypeConfigurationWritable=0