Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for package manager #17

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Conversation

Shrews
Copy link
Collaborator

@Shrews Shrews commented Mar 30, 2023

  • Fixes bug where we incorrecty assume dnf for python interpreter install
  • Add pulp tests that verify check_ansible and new pkg manager option
  • Change pulp setup to pull ubi-minimal instead of ubi-micro since we need a package manager.

- Fixes bug where we incorrecty assume dnf for python interpreter install
- Add pulp tests that verify check_ansible and new pkg manager option
@Shrews Shrews marked this pull request as ready for review March 30, 2023 18:47
@Shrews
Copy link
Collaborator Author

Shrews commented Mar 30, 2023

@Shrews Shrews requested a review from nitzmahone March 30, 2023 18:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.03 ⚠️

Comparison is base (68f363a) 85.68% compared to head (8fac1c0) 85.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@              Coverage Diff               @@
##           v3_hackery      #17      +/-   ##
==============================================
- Coverage       85.68%   85.65%   -0.03%     
==============================================
  Files              13       13              
  Lines             978      983       +5     
  Branches          213      216       +3     
==============================================
+ Hits              838      842       +4     
  Misses             89       89              
- Partials           51       52       +1     
Impacted Files Coverage Δ
ansible_builder/ee_schema.py 85.00% <75.00%> (-1.49%) ⬇️
ansible_builder/containerfile.py 94.97% <100.00%> (+0.05%) ⬆️
ansible_builder/user_definition.py 98.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nitzmahone nitzmahone merged commit 5ff84c7 into nitzmahone:v3_hackery Mar 31, 2023
@Shrews Shrews deleted the pkgmgr branch March 31, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants