Get wallet transactions runs without errors... needs testing

lib/providers/chain-state/btc/btc.js

@@ -105,27 +105,29 @@ BTCStateProvider.prototype.getWalletAddresses = async function(network, walletId
   Storage.apiStreamingFind(WalletAddress, query, stream);
 };
 
-BTCStateProvider.prototype.updateWallet = async function(chain, walletId, addresses) {
+BTCStateProvider.prototype.updateWallet = async function(network, walletId, addresses) {
   return WalletAddress.updateCoins(walletId, addresses);
 };
 
-BTCStateProvider.prototype.getWalletTransactions = async function(walletId, stream, args) {
+BTCStateProvider.prototype.getWalletTransactions = async function(network, walletId, stream, args) {
   let query = {
     wallets: walletId
   };
-  if (args.startBlock) {
-    query.blockHeight = { $gte: parseInt(args.startBlock) };
-  }
-  if (args.endBlock) {
-    query.blockHeight = query.blockHeight || {};
-    query.blockHeight.$lte = parseInt(args.endBlock);
-  }
-  if (args.startDate) {
-    query.blockTimeNormalized = { $gte: new Date(args.startDate) };
-  }
-  if (args.endDate) {
-    query.blockTimeNormalized = query.blockTimeNormalized || {};
-    query.blockTimeNormalized.$lt = new Date(args.endDate);
+  if(args) {
+    if (args.startBlock) {
+      query.blockHeight = { $gte: parseInt(args.startBlock) };
+    }
+    if (args.endBlock) {
+      query.blockHeight = query.blockHeight || {};
+      query.blockHeight.$lte = parseInt(args.endBlock);
+    }
+    if (args.startDate) {
+      query.blockTimeNormalized = { $gte: new Date(args.startDate) };
+    }
+    if (args.endDate) {
+      query.blockTimeNormalized = query.blockTimeNormalized || {};
+      query.blockTimeNormalized.$lt = new Date(args.endDate);
+    }
   }
   let transactionStream = Transaction.getTransactions({query});
   let listTransactionsStream = new ListTransactionsStream(walletId);
@@ -146,7 +148,7 @@ BTCStateProvider.prototype.getWalletUtxos = async function(walletId, stream, arg
 };
 
 /*
- *BTCStateProvider.prototype.broadcastTransaction = async function(chain, tx) {
+ *BTCStateProvider.prototype.broadcastTransaction = async function(network, tx) {
  *  return this.get(chain).broadcastTransaction(tx);
  *};
  */

lib/providers/chain-state/btc/transforms.js

@@ -85,4 +85,4 @@ ListTransactionsStream.prototype._transform = function(transaction, enc, done) {
   done();
 };
 
-
+module.exports = ListTransactionsStream;

lib/providers/chain-state/index.js

@@ -56,8 +56,8 @@ ChainStateProvider.prototype.updateWallet = async function (chain, network,  wal
   return this.get(chain).updateWallet(walletId);
 };
 
-ChainStateProvider.prototype.getWalletTransactions = async function (chain, network, walletId) {
-  return this.get(chain).getWalletTransactions(walletId);
+ChainStateProvider.prototype.getWalletTransactions = async function (chain, network, walletId, stream, args) {
+  return this.get(chain).getWalletTransactions(network, walletId, stream, args);
 };
 
 ChainStateProvider.prototype.getWalletBalance = async function (chain, network, walletId) {

lib/routes/wallet.js

@@ -57,6 +57,7 @@ router.get('/:walletId/addresses', async function(req, res) {
     }
     ChainStateProvider.getWalletAddresses(chain, network, walletId, res);
   } catch (err) {
+    console.error(err);
     return res.status(500).send(err);
   }
 });
@@ -166,30 +167,18 @@ ListTransactionsStream.prototype._transform = function(transaction, enc, done) {
 };
 
 router.get('/:walletId/transactions', async (req, res) => {
-  let wallet = await Wallet.findOne({ _id: req.params.walletId }).exec();
-  if (!wallet) {
-    return res.status(404).send(new Error('Wallet not found'));
-  }
-  var query = {
-    wallets: wallet._id
-  };
-  if (req.query.startBlock) {
-    query.blockHeight = { $gte: parseInt(req.query.startBlock) };
-  }
-  if (req.query.endBlock) {
-    query.blockHeight = query.blockHeight || {};
-    query.blockHeight.$lte = parseInt(req.query.endBlock);
-  }
-  if (req.query.startDate) {
-    query.blockTimeNormalized = { $gte: new Date(req.query.startDate) };
-  }
-  if (req.query.endDate) {
-    query.blockTimeNormalized = query.blockTimeNormalized || {};
-    query.blockTimeNormalized.$lt = new Date(req.query.endDate);
+  let {walletId} = req.params;
+  let {chain, network} = req.query;
+  try {
+    let wallet = await Wallet.findOne({ _id: req.params.walletId }).exec();
+    if (!wallet) {
+      return res.status(404).send(new Error('Wallet not found'));
+    }
+    ChainStateProvider.getWalletTransactions(chain, network, walletId, res);
+  } catch(err) {
+    console.error(err);
+    return res.status(500).send(err);
   }
-  var transactionStream = Transaction.getTransactions({query});
-  var listTransactionsStream = new ListTransactionsStream(wallet._id);
-  transactionStream.pipe(listTransactionsStream).pipe(res);
 });
 
 router.get('/:walletId/balance', async (req, res) => {