Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raw): add .sql to raw file extensions #2745

Merged

Conversation

mbegerau
Copy link
Contributor

πŸ”— Linked issue

#2666 [useStorage] getItem and getItemRaw -> Inconsistent behaviour between dev and preview/production

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The change adds the .sql extension and the application/sql mime type (that is what the mime library assigns to .sql files) to the list of file types that are stored as string and not as Uint8Array.

That makes the process to use the server:assets storage for .sql files straightforward and intuitive.

Resolves partly #2666
The change does not solve the issue that useStorage acts differently in dev and production environment, but it solves the problem that .sql files are not stored as string.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title enhancement: add .sql to raw file extensions feat(raw): add .sql to raw file extensions Sep 23, 2024
@pi0 pi0 merged commit 05aa182 into nitrojs:v2 Sep 23, 2024
4 checks passed
@pi0 pi0 mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants