-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix types for cloudflare:queue
args
#2626
Conversation
cloudflare:queue
args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
additional fix: types for cloudflare:queue args CloudflareEmailContext.raw to ReadableStream<Uint8Array> from ReadableStream |
I have something additional to ask. Testing with Nuxt nightly. The error occurs during the build process.
I would like to ask whether this is also a problem with Nitro and, if so, where I should fix it. |
I don't know think so. Maybe this rule or "cloudflare-email-kit" plugin is fault. Before, "cloudflare-email-kit" module's dependency is all of "browser" dependencies. So, I think that rules is problem... ADD: I added this rule. So, It works. (??) if (
id.startsWith("cloudflare:")
) {
return { id, external: true };
} |
Thanks for PR. Fixed via #2711 |
π Linked issue
β Type of change
π Description
The queue event(MessageBatch) is wrong types.
What was originally supposed to be MessageBatch, I looked it up today and found that it was written as CloudflareEmailContext.
I just fixed it.
π Checklist
#2587 (comment)