Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(playground): does not overwrite tsconfig.paths #2507

Merged
merged 3 commits into from
Jun 12, 2024
Merged

chore(playground): does not overwrite tsconfig.paths #2507

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
234fd6c
chore(playground): does not overwrite generate tsconfig paths
Barbapapazes Jun 10, 2024
1b96db6
Apply suggestions from code review
Barbapapazes Jun 10, 2024
94d33f2
Merge branch 'main' into pr/Barbapapazes/2507
pi0 Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion playground/nitro.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
import { defineNitroConfig } from "nitropack/config";

export default defineNitroConfig({});
export default defineNitroConfig({
typescript: {
// Because the TSConfig extends properties is not a merge but overwrite keys, we loose the paths from the NitroPack TSConfig.
Barbapapazes marked this conversation as resolved.
Show resolved Hide resolved
tsConfig: {
compilerOptions: {
paths: {
nitropack: ["../../../src/index"],
"nitropack/config": ["../../../src/config"],
"#internal/nitro": ["../../../src/runtime/index"],
"#internal/nitro/*": ["../../../src/runtime/*"],
},
},
},
},
});
10 changes: 1 addition & 9 deletions playground/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
{
"extends": "./.nitro/types/tsconfig.json",
"compilerOptions": {
"paths": {
"nitropack": ["../src/index"],
"nitropack/config": ["../src/config"],
"#internal/nitro": ["../src/runtime/index"],
"#internal/nitro/*": ["../src/runtime/*"]
}
}
"extends": "./.nitro/types/tsconfig.json"
}