Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): correctly handle maxAge cookie option #2400

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix(azure): correctly handle maxAge cookie option #2400

merged 1 commit into from
Apr 29, 2024

Conversation

julien1619
Copy link
Contributor

@julien1619 julien1619 commented Apr 29, 2024

πŸ”— Linked issue

#2399

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

In the utils that sets cookies for Azure, it is lowercasing the cookie keys at line 24:

const setCookieOptions = Object.fromEntries(
      _setCookieOptions.map(([k, v]) => [k.toLowerCase(), v])
);

But uses the camelCase key a few lines later:

maxAge: parseNumber(setCookieOptions.maxAge),

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@julien1619
Copy link
Contributor Author

I'm testing the fix in my private application right now.

@pi0 pi0 changed the title fix(azure): cookies maxAge not set in azure preset fix(azure): correctly handle maxAge cookie option Apr 29, 2024
@pi0 pi0 merged commit 1e506ac into nitrojs:main Apr 29, 2024
4 checks passed
pi0 pushed a commit to igorjacauna/nitro that referenced this pull request Apr 29, 2024
@julien1619
Copy link
Contributor Author

Really sorry @pi0, but after running some more tests, the real fix is:

maxAge: parseNumber(setCookieOptions['max-age']),

@pi0
Copy link
Member

pi0 commented Apr 29, 2024

Feel free to make another PR πŸ‘πŸΌ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants