Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose getRouteRulesForPath from nitro runtime #2238

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This exposes getRouteRulesForPath from #internal nitro. We could use it in Nuxt (context) to avoid duplicating this logic or importing deeply from the runtime directory.

Not sure if there was a reason it was explicitly not exposed previously.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 March 9, 2024 15:37
@danielroe danielroe self-assigned this Mar 9, 2024
@pi0 pi0 changed the title fix: expose getRouteRulesForPath from nitro runtime feat: expose getRouteRulesForPath from nitro runtime Mar 10, 2024
@pi0
Copy link
Member

pi0 commented Mar 10, 2024

We need to make (type) read-only before exposing util.

@danielroe
Copy link
Member Author

Should be good to go πŸ‘

@pi0 pi0 merged commit 09d23d6 into main Apr 3, 2024
5 checks passed
@pi0 pi0 deleted the fix/expose-grrfp branch April 3, 2024 11:55
@pi0 pi0 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants