fix(prerender): decode generated routes

[danielroe]

🔗 Linked issue

resolves nuxt/nuxt#22660
closes nuxt/nuxt#24320

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

When a link is rendered in HTML (e.g. by vue router) with URI components, Nitro currently does not decode these when requesting the URL, which can cause double encoding and a 404 from vue-router.

Instead we should likely decode the link at source, just as we do with headers.

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[pi0]

Can you please also add a test? 🙏🏼 (i am also not sure about this because we might wrongly decode/change original links. we could make it opt-in for nuxt as vue-router supports encoding for example but test case would be useful)

[danielroe]

The source of the double encoding is from this line:

https://github.com/unjs/nitro/blob/466535abcce71bd6c39a7fd7a698da4bbd2f7059/src/prerender.ts#L168-L169

I think if we are forcibly going to encode the URI (see #891) it makes sense to decode scanned links first.

[danielroe]

Okay, pushed a change that means route is always decoded. This covers both scanned links and link headers, as well as ensuring that we write the decoded version to the file system. ✅