-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support useRuntimeConfig(event) in all presets without unenv #1318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1318 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 73 73
Lines 7550 7550
Branches 745 746 +1
=======================================
Hits 5767 5767
Misses 1782 1782
Partials 1 1 |
f645fef
to
7f840dc
Compare
β Live Preview ready!
|
9f86263
to
508c6cd
Compare
508c6cd
to
c6f9d6e
Compare
b235dfb
to
695c678
Compare
pi0
reviewed
Jul 19, 2023
3ded174
to
591038b
Compare
591038b
to
d25643d
Compare
This was referenced Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
fix: #272
related: #1150
β Type of change
π Description
This allows cloudflare environment variables to use
runtimeConfig
without unenv unjs/unenv#95Assuming the following environment variables are bound to the worker :
The following will work as expected :
Note that using event is optional.
π Checklist