chore: type check errors running tsc (#269)

Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Pooya Parsa <[email protected]>

.github/workflows/ci.yml

@@ -21,6 +21,7 @@ jobs:
           cache: pnpm
       - run: pnpm install
       - run: pnpm lint
+      - run: pnpm test:types
       - run: pnpm build
       - run: pnpm vitest --coverage
       - uses: codecov/codecov-action@v3

examples/tsconfig.json

@@ -0,0 +1,4 @@
+{
+    "extends": "../tsconfig.json",
+    "include": ["."]
+}

package.json

@@ -32,7 +32,8 @@
     "prepack": "pnpm build",
     "release": "pnpm test && pnpm build && standard-version && pnpm publish && git push --follow-tags",
     "stub": "unbuild --stub",
-    "test": "pnpm lint && vitest run --silent"
+    "test": "pnpm lint && vitest run --silent",
+    "test:types": "tsc --noEmit"
   },
   "resolutions": {
     "nitropack": "link:."

src/presets/aws-lambda.ts

@@ -1,6 +1,5 @@
 import { defineNitroPreset } from '../preset'
 
 export const awsLambda = defineNitroPreset({
-  entry: '#internal/nitro/entries/aws-lambda',
-  externals: true
+  entry: '#internal/nitro/entries/aws-lambda'
 })

src/presets/azure-functions.ts

@@ -9,7 +9,6 @@ import type { Nitro } from '../types'
 export const azureFunctions = defineNitroPreset({
   serveStatic: true,
   entry: '#internal/nitro/entries/azure-functions',
-  externals: true,
   commands: {
     deploy: 'az functionapp deployment source config-zip -g <resource-group> -n <app-name> --src {{ output.dir }}/deploy.zip'
   },

src/presets/azure.ts

@@ -7,7 +7,6 @@ import type { Nitro } from '../types'
 
 export const azure = defineNitroPreset({
   entry: '#internal/nitro/entries/azure',
-  externals: true,
   output: {
     serverDir: '{{ output.dir }}/server/functions'
   },

src/presets/firebase.ts

@@ -9,7 +9,6 @@ import type { Nitro } from '../types'
 
 export const firebase = defineNitroPreset({
   entry: '#internal/nitro/entries/firebase',
-  externals: true,
   commands: {
     deploy: 'npx firebase deploy'
   },

src/presets/node.ts

@@ -1,6 +1,5 @@
 import { defineNitroPreset } from '../preset'
 
 export const node = defineNitroPreset({
-  entry: '#internal/nitro/entries/node',
-  externals: true
+  entry: '#internal/nitro/entries/node'
 })

src/presets/stormkit.ts

@@ -2,7 +2,6 @@ import { defineNitroPreset } from '../preset'
 
 export const stormkit = defineNitroPreset({
   entry: '#internal/nitro/entries/stormkit',
-  externals: true,
   output: {
     dir: '{{ rootDir }}/.stormkit'
   }

src/rollup/config.ts

@@ -231,7 +231,7 @@ export const plugins = [
 
   // Externals Plugin
   if (!nitro.options.noExternals) {
-    rollupConfig.plugins.push(externals(defu(nitro.options.externals as any, {
+    rollupConfig.plugins.push(externals(defu(nitro.options.externals, {
       outDir: nitro.options.output.serverDir,
       moduleDirectories: nitro.options.nodeModulesDirs,
       external: [

src/runtime/app.ts

@@ -35,7 +35,7 @@ function createNitroApp (): NitroApp {
   const routerOptions = createMatcher({ routes: config.nitro.routes })
 
   for (const h of handlers) {
-    let handler = h.lazy ? lazyEventHandler(h.handler as any) : h.handler
+    let handler = h.lazy ? lazyEventHandler(h.handler) : h.handler
 
     const referenceRoute = h.route.replace(/:\w+|\*\*/g, '_')
     const routeOptions = routerOptions.lookup(referenceRoute) || {}

src/runtime/client.ts

@@ -1,6 +1,7 @@
 // Client polyfill
 import { $fetch } from 'ohmyfetch'
+import { $Fetch, NitroFetchRequest } from '../types'
 
 if (!globalThis.$fetch) {
-  globalThis.$fetch = $fetch
+  globalThis.$fetch = $fetch as $Fetch<unknown, NitroFetchRequest>
 }

src/runtime/entries/netlify-edge.ts

@@ -13,14 +13,15 @@ export default async function (request: Request, _context) {
     url: url.pathname + url.search,
     host: url.hostname,
     protocol: url.protocol,
+    // @ts-ignore TODO
     headers: request.headers,
     method: request.method,
     redirect: request.redirect,
     body
   })
 
   return new Response(r.body, {
-    headers: r.headers,
+    headers: r.headers as HeadersInit,
     status: r.status,
     statusText: r.statusText
   })

src/runtime/entries/service-worker.ts

@@ -30,12 +30,14 @@ async function handleEvent (url, event) {
   })
 
   return new Response(r.body, {
-    headers: r.headers,
+    headers: r.headers as HeadersInit,
     status: r.status,
     statusText: r.statusText
   })
 }
 
+declare const self: ServiceWorkerGlobalScope
+
 self.addEventListener('install', () => {
   self.skipWaiting()
 })

src/runtime/virtual/server-handlers.d.ts

@@ -1,11 +1,14 @@
-import type { CompatibilityEventHandler, RouterMethod } from 'h3'
+import type { CompatibilityEventHandler, LazyEventHandler, RouterMethod } from 'h3'
 
-interface HandlerDefinition {
+type HandlerDefinition = {
   route: string
   lazy?: boolean
   middleware?: boolean
-  handler: CompatibilityEventHandler | (() => Promise<CompatibilityEventHandler>)
+  handler: CompatibilityEventHandler
   method?: RouterMethod
+} & {
+  lazy: true
+  handler: LazyEventHandler
 }
 
 export const handlers: HandlerDefinition[]

src/runtime/virtual/storage.d.ts

@@ -1,3 +1,3 @@
 import type { Storage } from 'unstorage'
 
-export const useStorage = () => Storage
+export declare const useStorage: () => Storage

tsconfig.json

@@ -4,7 +4,8 @@
     "allowSyntheticDefaultImports": true,
     "skipLibCheck": true,
     "lib": [
-      "WebWorker"
+      "WebWorker",
+      "DOM.Iterable"
     ],
     "target": "ESNext",
     "module": "ESNext",
@@ -27,6 +28,8 @@
   "include": [
     "src",
     "test",
-    "examples"
+  ],
+  "exclude": [
+    "test/fixture"
   ]
 }