Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Directory.Build.props as single source of version information #1373

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Jul 2, 2024

Now Directory.Build.props's version number in <VersionPrefix> is the single source of truth for the version (and other metadata) information. No need to copy paste and sync multiple files.

This is what the DLL metadata looks with local (Release) build:

image

fixes #1372

@lahma lahma requested a review from tonyqus July 2, 2024 06:59
@tonyqus
Copy link
Member

tonyqus commented Jul 2, 2024

LGTM.

THank you!

@tonyqus tonyqus added the cicd label Jul 2, 2024
@tonyqus tonyqus added this to the NPOI 2.7.1 milestone Jul 2, 2024
@tonyqus tonyqus merged commit a0e8501 into nissl-lab:master Jul 2, 2024
3 checks passed
@lahma lahma deleted the single-version-source branch July 2, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CICD script doesn't update the version number of the nuget package after updating to 2.7.1
2 participants