Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix URLs on pull_request_template.md #422

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

nick-y-ito
Copy link
Member

@nick-y-ito nick-y-ito commented Aug 5, 2024

Overview

Fixed wrong URLs on pull_request_template.md.

Notes

Assignee Checklist:

  • The naming convention of the PR title is correct (See the comment at the top of this template)
  • The base branch is correct (See: Types of Branches)
  • The branch name follows the Branch Naming Conventions
  • The correct assignees and reviewers have been designated for this PR
  • The coding style follows the Coding Style Guide
  • All the related issues are associated with this PR
  • All criteria in the associated issues are met (please tick the checkboxes)
  • My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

  • Double-check the "Assignee Checklist"
  • The code follows the generic best practices and our Coding Style Guide
  • The code is well-commented and easy to understand
  • The UI changes accurately reflect the provided design

@nick-y-ito nick-y-ito self-assigned this Aug 5, 2024
Copy link
Member

@ShoeheyOt ShoeheyOt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-y-ito
Copy link
Member Author

@ShoeheyOt Thank you!

@nick-y-ito nick-y-ito merged commit dec5310 into develop Aug 6, 2024
5 checks passed
@nick-y-ito nick-y-ito deleted the docs/fix-links-on-pull-request-template branch August 6, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants