bug: valgrind throws when importing into FileManager into Config

nirv-ai · Mar 15, 2023 · f139355 · f139355
1 parent a83ddba
commit f139355
Show file tree

Hide file tree

Showing 3 changed files with 163 additions and 28 deletions.
diff --git a/src/boat/private/Config.nim b/src/boat/private/Config.nim
@@ -21,10 +21,7 @@ import std/[
   strutils,
 ]
 
-# TODO: simply importing FileManager causes valgrind to throw
-# ^ weird cuz nothing is in there but stubs
-import BoatErrors, BoatConstants
-
+import BoatErrors, BoatConstants, FileManager
 
 type Config* = ref object of RootObj
   use*: string ## \

diff --git a/src/boat/private/FileManager.nim b/src/boat/private/FileManager.nim
@@ -5,10 +5,11 @@
 
 import ../../../bdd
 
+# valgrind throws if this file is imported into ./Config.nim
 import std/[
-    asyncdispatch,
+    asyncdispatch, # causes valgrind to throw
     locks,
-    threadpool,
+    threadpool, # causes valgrind to throw
   ]
 
 import BoatConstants, BoatErrors

diff --git a/testresults.html b/testresults.html