Add nirum syntax highlighting to docs target #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qria
commented
Aug 20, 2018
•
qria
commented
qria
force-pushed
the
highlight-nirum
branch
2 times, most recently
from
40aa611 to
2354749
Compare
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
========================================
- Coverage 76.48% 76% -0.49%
========================================
Files 33 34 +1
Lines 2905 2926 +21
Branches 198 198
========================================
+ Hits 2222 2224 +2
- Misses 485 504 +19
Partials 198 198
Continue to review full report at Codecov.
|
dahlia
requested changes
Aug 20, 2018
CHANGES.md
Outdated
| @@ -31,8 +31,8 @@ To be released. | |||
| [[#297], [#304] by Jeong Ukjae] | |||
| - Added `opengraphs` option for [OpenGraph] objects on docs. | |||
| [[#283], [#305] by GyuYong Jung] | |||
| - Added syntax highlighting. | |||
| [[#310], [#311] by MinJune Kim] | |||
| - Added syntax highlighting including nirum. | |||
src/Nirum/Targets/Docs.hs
Outdated
| return { | ||
| [keywords]: { | ||
| keyword: 'record enum unboxed type union service' + | ||
| ' import throws as default', |
There was a problem hiding this comment.
Vertical aligment should be adjusted.
src/Nirum/Targets/Docs.hs
Outdated
| keyword: 'record enum unboxed type union service' + | ||
| ' import throws as default', | ||
| built_in: 'bigint decimal int32 int64 float32 float64' + | ||
| ' text binary datetime date bool uuid uri', |
There was a problem hiding this comment.
Verical aligment should be adjusted.
src/Nirum/Targets/Docs.hs
Outdated
| compilePackage' :: Package Docs -> Map FilePath (Either Error BS.ByteString) | ||
| compilePackage' pkg = unions | ||
| [ fromList | ||
| [ ("style.css", Right $ encodeUtf8 css) | ||
| , ("nirum.js", Right $ encodeUtf8 javascript) | ||
| , ("nirumHighlight.js" | ||
| , Right $ encodeUtf8 $ TL.toStrict nirumHighlightJavascript) |
There was a problem hiding this comment.
The closing parenthesis should be aligned to the opening parenthesis and commas.
src/Nirum/Targets/Docs.hs
Outdated
| compilePackage' :: Package Docs -> Map FilePath (Either Error BS.ByteString) | ||
| compilePackage' pkg = unions | ||
| [ fromList | ||
| [ ("style.css", Right $ encodeUtf8 css) | ||
| , ("nirum.js", Right $ encodeUtf8 javascript) | ||
| , ("nirumHighlight.js" |
There was a problem hiding this comment.
If a pair of parentheses contain multiple lines a whitespace should be placed right after the opening parenthesis.
|
@dahlia fixed as requested |
kanghyojun
reviewed
Aug 21, 2018
src/Nirum/Targets/Docs.hs
Outdated
| ' import throws as default', | ||
| built_in: 'bigint decimal int32 int64 float32 float64' + | ||
| ' text binary datetime date bool uuid uri', | ||
| literal: 'true false', |
There was a problem hiding this comment.
I think there are no literal called true or false in Nirum IDL
kanghyojun
approved these changes
Aug 21, 2018
dahlia
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.