Add syntax highlighting for doc target #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qria
commented
Aug 16, 2018
•
qria
commented
dahlia
requested changes
Aug 16, 2018
src/Nirum/Targets/Docs.hs
Outdated
| ] | ||
| hljsJs :: T.Text | ||
| hljsJs = T.concat | ||
| [ "https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.12.0/" |
There was a problem hiding this comment.
As hljsJs and hljsCss share the common prefix, how about extract out the common prefix? It would be also helpful when we need to upgrade the version of the highlight.js library.
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 76.19% 76.22% +0.02%
==========================================
Files 34 34
Lines 2899 2902 +3
Branches 194 194
==========================================
+ Hits 2209 2212 +3
Misses 496 496
Partials 194 194
Continue to review full report at Codecov.
|
dahlia
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.