Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional parameters omittable #280

Merged
merged 1 commit into from
May 24, 2018

Conversation

dahlia
Copy link
Member

@dahlia dahlia commented May 23, 2018

According to the serialization specification, method parameters that have an optional type should can be omitted and treated as None if omitted. As this behavior was missing from the previous PR #278, this patch fixes that.

@dahlia dahlia added typ:bug Type: Bug/defect cmp:transport Component: Transports cmp:runtime Component: Target runtimes target:python labels May 23, 2018
@dahlia dahlia self-assigned this May 23, 2018
@dahlia dahlia requested a review from kanghyojun May 23, 2018 18:53
@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #280 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #280      +/-   ##
=========================================
- Coverage   77.21%   77.2%   -0.02%     
=========================================
  Files          34      34              
  Lines        2669    2672       +3     
  Branches      144     144              
=========================================
+ Hits         2061    2063       +2     
- Misses        464     465       +1     
  Partials      144     144
Impacted Files Coverage Δ
src/Nirum/Targets/Python.hs 88.17% <66.66%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454e4b6...435b82f. Read the comment docs.

@dahlia dahlia merged commit fa13a7f into nirum-lang:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:runtime Component: Target runtimes cmp:transport Component: Transports target:python typ:bug Type: Bug/defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants