Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric-constraints annotation #271

Closed

Conversation

earlbread
Copy link
Contributor

@earlbread earlbread commented May 12, 2018

Close #206

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #271 into master will increase coverage by 0.37%.
The diff coverage is 58.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   76.11%   76.48%   +0.37%     
==========================================
  Files          34       33       -1     
  Lines        2906     2905       -1     
  Branches      195      198       +3     
==========================================
+ Hits         2212     2222      +10     
+ Misses        499      485      -14     
- Partials      195      198       +3
Impacted Files Coverage Δ
src/Nirum/Targets/Python.hs 87.16% <58.82%> (-1.02%) ⬇️
..._64-osx/Cabal-2.2.0.1/build/autogen/Paths_nirum.hs
src/Nirum/Targets/Python/CodeGen.hs 88.53% <0%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3eea56...7fab1c3. Read the comment docs.

Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please write docs about the added @numeric-constraints annotation in the Common annotations section of the docs/annotation.md file.
  • Could you rebase 7f549ca on master rather than merging master (i.e., 9d15860)?

@earlbread earlbread force-pushed the add-numeric-constraints branch from 9d15860 to 7fab1c3 Compare August 17, 2018 07:52
@earlbread
Copy link
Contributor Author

I wrote docs and rebased the branch. @dahlia

@dahlia dahlia force-pushed the add-numeric-constraints branch from 7fab1c3 to 74708ea Compare August 17, 2018 14:51
dahlia added a commit to earlbread/nirum that referenced this pull request Aug 17, 2018
dahlia
dahlia previously approved these changes Aug 17, 2018
@earlbread earlbread force-pushed the add-numeric-constraints branch from 74708ea to 7fab1c3 Compare August 17, 2018 15:07
dahlia added a commit that referenced this pull request Aug 17, 2018
dahlia added a commit that referenced this pull request Aug 17, 2018
@dahlia
Copy link
Member

dahlia commented Aug 17, 2018

Merged: f2edb0f.

@dahlia dahlia closed this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants