Make generated Python codes free from validate_*() runtime functions #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from: nirum-lang#244
Whereas GNU sed's -i/--in-place option optionally takes an argument (which is a suffix, and means to modify the input file in place if you omit an argument), BSD sed's -i option always takes an argument even if it's an empty string (e.g., -i ''). My solution is install GNU sed using Homebrew on macOS build. Note that omitting --with-default-names will prepend "g" to the command, i.e., gsed. Cherry-picked from: nirum-lang#244
dahlia
added
typ:bug
Checklist 🤔
|
kanghyojun
previously approved these changes
Mar 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 73.51% 72.96% -0.56%
==========================================
Files 31 33 +2
Lines 2254 2341 +87
Branches 126 130 +4
==========================================
+ Hits 1657 1708 +51
- Misses 471 503 +32
- Partials 126 130 +4
Continue to review full report at Codecov.
|
|
More changes were added:
|
kanghyojun
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch basically deals with a part of #160, with several other changes related to it.
validate_*()runtime functions that nirum-python library provides. See also addedNirum.Targets.Python.Validatorsmodule.datetimevalue.*_Clientclasses don't validate their arguments #220.uribecame represented asbasestringinstead ofunicode, since URI (unlike IRI) is limited to a subset of ASCII character set.See also CHANGES.md.