Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve document design #170

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Improve document design #170

merged 1 commit into from
Aug 17, 2017

Conversation

AiOO
Copy link
Collaborator

@AiOO AiOO commented Aug 15, 2017

TBD 👶

@dahlia
Copy link
Member

dahlia commented Aug 15, 2017

@AiOO hlint seems unsatisfied:

src/Nirum/Targets/Docs.hs:351:51: Suggestion: Redundant $

Found:

  TL.toStrict $ stylesheet

Why not:

  TL.toStrict stylesheet

@dahlia dahlia self-requested a review August 15, 2017 11:43
@dahlia dahlia added cat:docs Category: Documentation typ:enhance Type: Enhancement/new feature labels Aug 15, 2017
@AiOO AiOO force-pushed the improve/make-document-complete-again branch from 8c70ee9 to df54d21 Compare August 17, 2017 00:44
dahlia
dahlia approved these changes Aug 17, 2017
View reviewed changes
Copy link
Member

@dahlia dahlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dahlia dahlia merged commit fe905b8 into nirum-lang:master Aug 17, 2017
@kanghyojun
Copy link
Member

ㅋㅋㅋㅋㅋㅋㅋ

@AiOO
Copy link
Collaborator Author

AiOO commented Aug 17, 2017

TB..D..... 😢

@dahlia dahlia added the cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) label Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlia dahlia dahlia approved these changes

Assignees

@AiOO AiOO

Labels
cat:docs Category: Documentation cmp:compiler Component: Compiler backend (e.g., annotation processors, code generators) typ:enhance Type: Enhancement/new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AiOO @dahlia @kanghyojun