Lint

src/Nirum/Constructs/TypeDeclaration.hs

@@ -207,10 +207,10 @@ instance Construct TypeDeclaration where
       where
         fieldsCode = T.intercalate "\n" $ map toCode $ toList fields'
         docs' = A.lookupDocs annotationSet'
-    toCode (TypeDeclaration name' (UnionType tags' defaultTag') annotationSet') =
-        T.concat [ toCode annotationSet'
+    toCode (TypeDeclaration name' (UnionType tags' defaultTag') as') =
+        T.concat [ toCode as'
                  , "union ", nameCode
-                 , toCodeWithPrefix "\n    " (A.lookupDocs annotationSet')
+                 , toCodeWithPrefix "\n    " (A.lookupDocs as')
                  , "\n    = " , tagsCode
                  , "\n    ;"
                  ]
@@ -227,12 +227,12 @@ instance Construct TypeDeclaration where
                                  ]
     toCode (TypeDeclaration name'
                             (PrimitiveType typename' jsonType')
-                            annotationSet') =
-        T.concat [ toCode annotationSet'
+                            as') =
+        T.concat [ toCode as'
                  , "// primitive type `", toCode name', "`\n"
                  , "//     internal type identifier: ", showT typename', "\n"
                  , "//     coded to json ", showT jsonType', " type\n"
-                 , docString (A.lookupDocs annotationSet')
+                 , docString (A.lookupDocs as')
                  ]
       where
         showT :: Show a => a -> T.Text

src/Nirum/Parser.hs

@@ -476,7 +476,10 @@ unionTypeDeclaration = do
 
         if length (L.filter snd tags') > 1
             then fail "`union` have to has only 1 default tag."
-            else return $ TypeDeclaration typename (UnionType remainTagSet defaultTag) annotationSet''
+            else return $ TypeDeclaration
+                              typename
+                              (UnionType remainTagSet defaultTag)
+                              annotationSet''
 
 typeDeclaration :: Parser TypeDeclaration
 typeDeclaration = do
@@ -603,7 +606,7 @@ imports = do
     spaces
     char '('
     spaces
-    idents <- (importName >>= \i -> spaces >> return i)
+    idents <- (importName >>= \ i -> spaces >> return i)
         `sepEndBy1` (char ',' >> spaces)
         <?> "names to import"
     char ')'

src/Nirum/Targets/Docs.hs

@@ -234,7 +234,7 @@ typeDecl mod' ident
 |]
   where
     enumerate :: [a] -> [(Int, a)]
-    enumerate = zip [0..]
+    enumerate = zip [0 ..]
     enumerateParams :: DES.DeclarationSet S.Parameter -> [(Int, S.Parameter)]
     enumerateParams = enumerate . DES.toList
 typeDecl _ _ TD.Import {} =

src/Nirum/Targets/Python.hs

@@ -581,7 +581,8 @@ if hasattr($parentClass, '__qualname__'):
     fieldList :: [Field]
     fieldList = toList fields
     nameMaps :: Code
-    nameMaps = toIndentedCodes toNamePair (map fieldName fieldList) ",\n        "
+    nameMaps = toIndentedCodes
+        toNamePair (map fieldName fieldList) ",\n        "
     parentClass :: T.Text
     parentClass = toClassName' parentname
     fieldSerializers :: Code
@@ -1076,7 +1077,6 @@ class #{className}(#{T.intercalate "," $ compileExtendClasses annotations}):
         if isinstance(value, dict) and '_tag' not in value:
             value = dict(value)
             value['_tag'] = '#{toBehindSnakeCaseText $ tagName dt}'
-            value['_type'] = '#{toAttributeName' typename'}'
 %{ of Nothing }
 %{ endcase }
         if '_type' not in value:
@@ -1121,7 +1121,8 @@ class #{className}(#{T.intercalate "," $ compileExtendClasses annotations}):
             else:
                 name = attribute_name
             tag_types = cls.__nirum_tag_types__
-            if callable(tag_types):  # old compiler could generate non-callable map
+            # old compiler could generate non-callable map
+            if callable(tag_types):
                 tag_types = dict(tag_types())
             try:
                 args[name] = deserialize_meta(tag_types[name], item)

test/Nirum/Constructs/TypeDeclarationSpec.hs

@@ -159,7 +159,12 @@ union shape
                 nullDecl' =
                     ServiceDeclaration "null-service" nullService
                                        (singleDocs "Null service declaration.")
-                pingService = Service [ Method "ping" [] (Just "bool") Nothing empty ]
+                pingService = Service [ Method
+                                            "ping"
+                                            []
+                                            (Just "bool")
+                                            Nothing
+                                            empty ]
                 pingDecl = ServiceDeclaration "ping-service" pingService empty
                 pingDecl' =
                     ServiceDeclaration "ping-service" pingService

test/Nirum/ParserSpec.hs

@@ -842,14 +842,14 @@ union shape
             parse' "text get-name (person user)" `shouldBeRight`
                 Method "get-name" [Parameter "user" "person" empty]
                        (Just "text") Nothing empty
-            parse' "text get-name  ( person user,text `default` )" `shouldBeRight`
+            parse' "text get-name (person user,text `default`)" `shouldBeRight`
                 Method "get-name"
                        [ Parameter "user" "person" empty
                        , Parameter "default" "text" empty
                        ]
                        (Just "text") Nothing empty
             parse' "@http(method = \"GET\", path = \"/get-name/\") \
-                   \text get-name  ( person user,text `default` )" `shouldBeRight`
+                   \text get-name (person user,text `default`)" `shouldBeRight`
                 Method "get-name"
                        [ Parameter "user" "person" empty
                        , Parameter "default" "text" empty