Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize recursively to deserialize boxed type #6

Merged
merged 1 commit into from
Jul 12, 2016

Conversation

kanghyojun
Copy link
Member

In nirum-lang/nirum#21, a boxed type boxes boxed type more then once, deserializer/serializer/validator dosen't work properly. so fix nirum-python functions to follow specification of nirum.

@dahlia
Copy link
Member

dahlia commented Jul 12, 2016

혹시 모르니까 세겹까지 테스트해보는 거 어떨까요 ㅋㅋ

@dahlia
Copy link
Member

dahlia commented Jul 12, 2016

그리고 boxed type → boxed type → primitive type 외에도 boxed type → alias → primitive type이라거나 alias → boxed type → primitive type도 테스트해보면 좋을 것 같습니다.

@kanghyojun
Copy link
Member Author

kanghyojun commented Jul 12, 2016

혹시 모르니까 세겹까지 테스트해보는 거 어떨까요 ㅋㅋ

이건 이미하고있어서 패스하는걸로

그리고 boxed type → boxed type → primitive type 외에도 boxed type → alias → primitive type이라거나 alias → boxed type → primitive type도 테스트해보면 좋을 것 같습니다.

이거 nirum쪽에서 테스트케이스로 넣는게 좋을거같아서 그쪽에 넣고 올릴게요 ㅋㅋ

@kanghyojun
Copy link
Member Author

제 브랜치에 올렸는데 확인해주실수있나요

@dahlia
Copy link
Member

dahlia commented Jul 12, 2016

@kanghyojun kanghyojun merged commit bc1fb46 into nirum-lang:master Jul 12, 2016
dahlia pushed a commit to dahlia/nirum-python that referenced this pull request Jan 11, 2018
Wildcard (*) pattern syntax for allowed_origins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants