Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance changes in 1.11 #79

Merged
merged 9 commits into from
Jan 11, 2024

Conversation

anushkamittal2001
Copy link

This PR will add performance changes to 1.11 n4k

@anushkamittal2001 anushkamittal2001 marked this pull request as ready for review December 14, 2023 09:38
Signed-off-by: anushkamittal2001 <[email protected]>
@anushkamittal2001 anushkamittal2001 changed the title optimize JSON context processing using in-memory map performance changes in 1.11 Dec 14, 2023
Signed-off-by: anushkamittal2001 <[email protected]>
Signed-off-by: anushkamittal2001 <[email protected]>
Signed-off-by: anushkamittal2001 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (a4457de) 33.36% compared to head (9b8d0e2) 33.48%.

Files Patch % Lines
pkg/engine/context/context.go 44.82% 41 Missing and 7 partials ⚠️
pkg/engine/context/utils.go 70.58% 10 Missing and 5 partials ⚠️
pkg/engine/jsonutils/convert.go 0.00% 11 Missing ⚠️
pkg/engine/jmespath/functions.go 72.72% 6 Missing and 3 partials ⚠️
pkg/engine/mutate/mutation.go 30.00% 6 Missing and 1 partial ⚠️
pkg/engine/context/mock_context.go 0.00% 6 Missing ⚠️
pkg/engine/handlers/mutation/load_targets.go 0.00% 6 Missing ⚠️
pkg/engine/utils/utils.go 0.00% 6 Missing ⚠️
pkg/engine/handlers/mutation/common.go 0.00% 2 Missing ⚠️
pkg/engine/jmespath/interface.go 33.33% 2 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release-1.11-n4k      #79      +/-   ##
====================================================
+ Coverage             33.36%   33.48%   +0.12%     
====================================================
  Files                   312      313       +1     
  Lines                 25055    25165     +110     
====================================================
+ Hits                   8359     8427      +68     
- Misses                15905    15942      +37     
- Partials                791      796       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: anushkamittal2001 <[email protected]>
Signed-off-by: anushkamittal2001 <[email protected]>
@anushkamittal2001 anushkamittal2001 merged commit e009ece into release-1.11-n4k Jan 11, 2024
117 of 121 checks passed
@anushkamittal2001 anushkamittal2001 deleted the 1.11.0-n4k.nirmata.2 branch August 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants