chore: move AMIs from instances to nodegroups #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kushal Beniwal <[email protected]>
pns-nirmata
reviewed
Apr 7, 2023
pns-nirmata
approved these changes
Apr 7, 2023
pns-nirmata
approved these changes
Apr 7, 2023
pns-nirmata
reviewed
Apr 7, 2023
| DiskSize *int32 `json:"diskSize,omitempty"` | ||
| AMIType string `json:"amiType,omitempty"` | ||
| CapacityType string `json:"capacityType,omitempty"` | ||
| AMIReleaseVersion *string `json:"amiReleaseVersion,omitempty"` |
There was a problem hiding this comment.
Are AMIType and AMIReleaseVersion also NodeGroup specific? Especially since we have an Array of AMIs in a nodegroup now?
Signed-off-by: Kushal Beniwal <[email protected]>
pns-nirmata
reviewed
Apr 7, 2023
| DiskSize *int32 `json:"diskSize,omitempty"` | ||
| AMIType string `json:"amiType,omitempty"` | ||
| CapacityType string `json:"capacityType,omitempty"` | ||
| AMIReleaseVersion *string `json:"amiReleaseVersion,omitempty"` |
There was a problem hiding this comment.
I think we should call this NodeGroupReleaseVersion or just ReleaseVersion (@anusha94 ?)
pns-nirmata
reviewed
Apr 7, 2023
| } | ||
|
|
||
| ami, err := getAmi(ctx, ec2Client, x.Reservations[0].Instances[0].ImageId) | ||
| if err != nil { |
There was a problem hiding this comment.
So it seems we are saving one of the many AMIs of the instances that a nodegroup might have. Because Nodegroup has a single AMIType, but multiple AMI Ids corresponding to that type, with variations in AMI fields like location, createtime, owner etc. Depending upon what fields of AMI are of interest, we might be ok with storing any one of the AMIs.
pns-nirmata
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AmazonMachineImagesfromInstancestoNodegroups.InstanceTypesfromNodeGroupstoAmazonMachineImages.ReservationsandNodegroups.